Update docs about script parameter
#27010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
rjernst
reviewed
Oct 13, 2017
| ---------------------- | ||
| "script": { | ||
| "source": "ctx._source.likes++" | ||
| } |
There was a problem hiding this comment.
nit: the closing curly should align with "script" above.
| @@ -98,8 +98,9 @@ parameter in the same way as the search api. | |||
| So far we've only been updating documents without changing their source. That | |||
| is genuinely useful for things like | |||
| <<picking-up-a-new-property,picking up new properties>> but it's only half the | |||
| fun. `_update_by_query` supports a `script` object to update the document. This | |||
| will increment the `likes` field on all of kimchy's tweets: | |||
| fun. `_update_by_query` supports a `script` object to update the document. | |||
There was a problem hiding this comment.
I think it would flow better to make the link inline. Something like:
`_update_by_query` also <<modules-scripting-using, supports scripts>>. The following will....
1. Wrong indentation of a bracket; 2. Making a link to `How to use scripts` inline.
|
@rjernst, |
rjernst
pushed a commit
that referenced
this pull request
Oct 16, 2017
Added a description of short script form. Also removed references to the obsolete `script.default_lang`.
rjernst
pushed a commit
that referenced
this pull request
Oct 16, 2017
Added a description of short script form. Also removed references to the obsolete `script.default_lang`.
jasontedor
added a commit
that referenced
this pull request
Oct 16, 2017
* master: Remove unnecessary exception for engine constructor Update docs about `script` parameter (#27010) Don't refresh on `_flush` `_force_merge` and `_upgrade` (#27000) Do not set SO_LINGER on server channels (#26997) Fix inconsistencies in the rest api specs for *_script (#26971) fix inconsistencies in the rest api specs for cat.snapshots (#26996) Add docs on full_id parameter in cat nodes API [TEST] Add test that replicates versioned updates with random flushes Use internal searcher for all indexing related operations in the engine Reformat paragraph in template docs to 80 columns Clarify settings and template on create index Fix reference to TcpTransport in documentation Allow Uid#decodeId to decode from a byte array slice (#26987) Fix a typo in the similarity docs (#26970) Use separate searchers for "search visibility" vs "move indexing buffer to disk (#26972)
jasontedor
added a commit
that referenced
this pull request
Oct 16, 2017
* 6.x: Remove unnecessary exception for engine constructor Update docs about `script` parameter (#27010) Do not set SO_LINGER on server channels (#26997) Fix inconsistencies in the rest api specs for *_script (#26971) fix inconsistencies in the rest api specs for cat.snapshots (#26996) Add docs on full_id parameter in cat nodes API Add removal of types to the 6.0 breaking changes Create weights lazily in filter and filters aggregation (#26983) [TEST] Add test that replicates versioned updates with random flushes Use internal searcher for all indexing related operations in the engine Use separate searchers for "search visibility" vs "move indexing buffer to disk (#26972) Reformat paragraph in template docs to 80 columns Clarify settings and template on create index Fix reference to TcpTransport in documentation Allow Uid#decodeId to decode from a byte array slice (#26987) Fix a typo in the similarity docs (#26970)
|
I've dropped the 6.0 tag from this because the support for the short form (#26841) is not in 6.1. |
nik9000
added a commit
that referenced
this pull request
Oct 16, 2017
This reverts commit bf5c6bd. The change that it documented is not in 6.0.
|
And reverted the change in 6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next changes were made:
scriptform was added.script.default_langconfig parameter was removed.@nik9000, Please have a look on these changes.
I've tested them with gradle and build them too. Everything seems ok...